Help my code is running very slowly..

Difficult to comment with certainty without seeing the request in the context of its workbook but avoid a loop and consider using Autofilter to first filter the rows you're trying to update and then add the relevant formulae to the filtered rows before removing the autofilter.

There's nothing particularly obvious in your code that's slowing things down.

Hard to find a good answer without seeing the workbook:

Are there many complex / volatile formuale? I'd suggest switching calculation to manual before running your code, then switch back to automatic (if necessary) afterwards, see if that helps speed things up.

Are there any workbook / worksheet change events being triggered by every value change? If so, try disabling application events.

And as always, disabling screenupdating helps speed things up.


To summarise:

Please Login or Register  to view this content.

Reading and writing cell by cell won't be quick. You can speed it up using arrays like this:

Please Login or Register  to view this content.

Try this

Please Login or Register  to view this content.

Originally Posted by apo

@Rory.. any advice on whether doing it like this is better/worse?

I doubt it will be significantly different - there may be an additional loop and function call in there but the same amount of data has to be processed either way.