Simple macro repetition, I am a total noob

I have a list of stock prices in excel that looks like this

stock prices needed 10/7/2014
UYM 50.85 51.42 49.88 49.93 6410.93
V 210.81 211.09 207.85 208.05 22375.57
VAC 61.52 61.75 60.48 60.58 1001.44
VAL 77.45 77.68 76.73 76.81 4599.69
VALE 11.34 11.58 11.29 11.39 362664.57
VAR 80.69 82.74 80.69 80.82 31238.55


they are the october 7 2014 open hi low and close and volume for the symbols in column a
the list is much longer than I've pasted

I need to copy the data for each stock and paste it into that stocks price file in the row for that particular date. the price file looks like this
10/03/2014 UYM 51.980 52.190 51.460 51.620 139
10/06/2014 UYM 51.820 52.120 51.400 51.600 185
10/07/2014 UYM 0 0 0 0 0
10/08/2014 UYM 49.66 51.04 48.52 51.01 277


i recorded a little macro which will performs the task for UYM. how to I tweak it so it will go down the list of stocks and copy and save the data for each one until I complete the entire list.

here is what I have so far

Please Login or Register  to view this content.

thank you!

Hello chart23,

Welcome to the Forum!

If you have a workbook you can post, it would help.

Please provide before and after examples of your data along with any notes you would like to include.

If your workbook contains any sensitive information, please redact that information before you post.

How To Post Your Workbook

1. At the bottom right of the Reply window, Click the button Go Advanced
2. At the top of the Your Message Window, in the first row of icons, Click the Paperclip icon.
3. Click the Add Files button at the top right in the dialog box. This displays the File Manager dialog.
4. Click the Select Files button at the bottom middle of the dialog.
5. In the new window Find the file you want to upload, select it, and Click Open.
6. You will now be back in the File Manager dialog. Click the bottom Middle button Upload File.
7. Wait until the file has completely uploaded before you exit the File Manager dialog.

What are you calling the source workbook? Does the source workbook have a sheet name? Does the destination? How should this macro reference the date?

Maybe something like this? Be sure to have a file backups located in another place. Macros that cycle through files multiple files can't be undone.

Please Login or Register  to view this content.

Could try spelling it out instead.

Please Login or Register  to view this content.

You'll need to try adjusting both references.

Set StockDate = Workbooks("fix prices.xls").Sheets("datsheet file").Range("C1")

For Each c In Workbooks("fix prices.xls").Sheets("datsheet file").Range("A1:A1000")

One issue it will have, is when no match exists.

When you type a formula into a cell and the formula doesn't work, you just get an error message.

When a formula doesn't work in VB, the VB crashes.

I sat and stared at the screen for a while until this made sense. I had a number of errors in the code.

I created an Analysis folder in C and then also created a UYM file and was able to get this to work. The biggest hangup was being caused by improper syntax of the MATCH function. In VB land, reference to sheets, cells, and filenames have to conform to object types. So instead of saying [uym.xls]Sheet1!blahblah I had to spell out Workbook(c & ".xls").Sheets("Sheet1").Range(blahblah)

The actual sheet name for your UYM file may differ.

Please Login or Register  to view this content.

It might have been.

Defining the dimensions of each variable isn't always necessary (depending on how it's used), but since the code was being a pain I was just being thorough when I went back.

No problem. I enjoy a good riddle, moreso when I can solve it.

Don't forget to mark the thread as solved, under Thread Options at the top.