Style vs substance?

[Rhudi]

I have two methods for writing code. The first way is how I write a certain routine.

Here is the before:

Please Login or Register  to view this content.

After that works, I simplify to this:

Please Login or Register  to view this content.

Now, I do realise that the first way is easier to trouble shoot and modify. But, the second doesn't use any variables and is "one line".

And, in this particular example, since the function is only one line, I can forgo the function call entirely.

So this:

Please Login or Register  to view this content.

Becomes this:

Please Login or Register  to view this content.

The last uses no extra variables and no function calls.
So, which is better / faster / tighter?

[Ron Coderre]

Good code is optimized for efficiency AND maintainability.
If you "got hit by a bus" and I had to maintain your code...I'd want to deal with your first snippet. I can see how the final result is derived. Long, run-on lines of code are confusing to work with and rarely give a clue about what they're trying to achieve.
(sort of like one of my pet peeves about "homework coders" who build code as if it only needs to run once and never get looked at again:
Example:
Would you rather work with this:

Please Login or Register  to view this content.

or this?:

Please Login or Register  to view this content.

)
Your last bit of code would make me have to explain why my shoe was sticking out of my computer monitor.

[shg]

Also, your 'simplified' code reads the cell eight times. That's very inefficient.

[Rhudi]

So, the "follow-up-ability" of code is absolutely paramount.

Plus, I'd love to have someone later look at some code I wrote and want to buy me a beer (not a bullet).