Execute code for first cell match

Hello,
It's been a while since I've posted anything, wondering if there is a different way to write following code. (I am trying to avoid the repeat scenario, i just want to focus on the first cell match even if there are duplicates.)

Sub test()
Dim rcell As Long
Dim PFI As String
Dim WS As Worksheet: Set WS = Sheets("Pro-Forma Invoice")
PFI = WS.Range("G5")

Windows("ORDERS 2014.xlsm").Activate
With Sheets("Pending Orders")
 ' so right over here i would like to change the code to only do the action to the first match the code will find instead of repeating the code for every match.   
For rcell = 5 To .Range("A" & Rows.Count).End(xlUp).Row
        If rcell Mod 2 = 1 Then
            If .Range("O" & rcell) = PFI Then
            .Range("O" & rcell).Select
            Selection.Hyperlinks(1).Follow NewWindow:=False, AddHistory:=True
            Range("A1").Value = "YOU DID IT!"
            End If
        End If
Next rcell
End With

End Sub

Thanks in advance

You can exit the loop once the code returns the first match.
After end if
exit sub or
exit for

Wow! That did the trick! Thanks

Originally Posted by AB33

You can exit the loop once the code returns the first match.
After end if
exit sub or
exit for

Hi AB33,
Little issue, this code works fine if the row where i'm taking action on is on the fifth line as stated in the code:

For rcell = 5 To .Range("A" & Rows.Count).End(xlUp).Row

However, if the row that i'm taking action on is on the 7th, 9th, 11th....etc, the code won't run.
Any ideas?

The code loops from row 5 to the bottom of column A. If the code finds the match in row 5, it exit the sub or loop. If the match is not found on 5, it goes to row 6, but the if if statement returns false on that row, then the code goes to next loop, row 7, if it finds match, then

.Range("O" & rcell).Hyperlinks(1).Follow NewWindow:=False, AddHistory:=True

is linked and the code exit the sub.
In other words, the code creates the hyper link using the row rcell and column O and exit the sub.

Originally Posted by AB33

The code loops from row 5 to the bottom of.......

I think i understand what you are saying but not 100% sure
Here is the code which i modified but it only works on row 5 but not any rows after that:

Sub test()
Dim rcell As Long
Dim PFI As String
Dim WS As Worksheet: Set WS = Sheets("Pro-Forma Invoice")
PFI = WS.Range("H7")

Windows("ORDERS 2014.xlsm").Activate
With Sheets("Pending Orders")

For rcell = 5 To .Range("O" & Rows.Count).End(xlUp).Row
        If rcell Mod 2 = 1 Then
            If .Range("O" & rcell) = PFI Then
            .Range("O" & rcell).Select
            Selection.Hyperlinks(1).Follow NewWindow:=False, AddHistory:=True
            Range("A1").Value = "YOU DID IT!"
            End If
        End If

Exit For

Next rcell
End With

End Sub

Kosherboy,
I might misunderstood your aim.
If the code returns true to the if condition on row5, there is nothing to be done on the loop. The code exit the loop. Since you do not have any other lines to execute- except the loop, the code will exit too-Goes to end sub.

I hear. So is there any alternative solutions?

There may be, but what is the objective? What are trying to do once a match is found?

You can try the find function.

i posted a random example but what i really want to do involves a long boring code.
Can i record the find function?

This is not a complete code, but will give you a good starting point for find function. Since I do not know what is your aim for this code, I have included next find function. The code does not look at odd rows, but all rows.

Option Explicit

Sub test()
Dim rcell As Long
Dim PFI As String
Dim rng As Range, FirstAddress As String
Dim ws As Worksheet: Set ws = Sheets("Pro-Forma Invoice")
PFI = ws.Range("H7")

Application.ScreenUpdating = 0
Windows("ORDERS 2014.xlsm").Activate
   With Sheets("Pending Orders").Columns("O")
      Set rng = .Find(PFI, .Cells(.Cells.Count), xlValues, xlWhole)
            If Not rng Is Nothing Then
              FirstAddress = rng.Address
               Do
                 .Cells(rng.Row, "O").Hyperlinks(1).Follow NewWindow:=False, AddHistory:=True
                 .Range("A1").Value = "YOU DID IT!"
                 Set rng = .FindNext(rng)
              Loop While Not rng Is Nothing And rng.Address <> FirstAddress
            End If
   End With
Application.ScreenUpdating = True
End Sub

Thanks!
i came up with this:

Sub Macro2()

Dim PFI As String
Dim WS As Worksheet: Set WS = Sheets("Pro-Forma Invoice")
PFI = WS.Range("H7")

Windows("ORDERS 2014.xlsm").Activate
With Sheets("Pending Orders")
Cells.Find(What:=PFI, After:=ActiveCell, LookIn:=xlFormulas, _
LookAt:=xlPart, SearchOrder:=xlByRows, SearchDirection:=xlNext, _
MatchCase:=False, SearchFormat:=False).Activate

ActiveCell.Hyperlinks(1).Follow NewWindow:=False, AddHistory:=True
Range("A1").Value = "YOU DID IT!"
End With

End Sub

Can you briefly explain what your version is doing "extra"?
Thanks!

Lots

Cells.Find(What:=PFI, After:=ActiveCell, LookIn:=xlFormulas, _
LookAt:=xlPart, SearchOrder:=xlByRows, SearchDirection:=xlNext, _
MatchCase:=False, SearchFormat:=False).Activate

need to be set as a range. your code will error if no match is found
Your code is looking in all cells, not just column O.

Ah! I see

OK, so ran your code but got an error message saying " Subscript out of range" for the highlighted part:

Option Explicit

Sub test3()
Dim rcell As Long
Dim PFI As String
Dim rng As Range, FirstAddress As String
Dim ws As Worksheet: Set ws = Sheets("Pro-Forma Invoice")
PFI = ws.Range("H7")

Application.ScreenUpdating = 0
Windows("ORDERS 2014.xlsm").Activate
   With Sheets("Pending Orders").Columns("O")
      Set rng = .Find(PFI, .Cells(.Cells.Count), xlValues, xlWhole)
            If Not rng Is Nothing Then
              FirstAddress = rng.Address
               Do
                 .Cells(rng.Row, "O").Hyperlinks(1).Follow NewWindow:=False, AddHistory:=True
                 .Range("A1").Value = "YOU DID IT!"
                 Set rng = .FindNext(rng)
              Loop While Not rng Is Nothing And rng.Address <> FirstAddress
            End If
   End With
Application.ScreenUpdating = True
End Sub

I do not know why you are getting an error, try

 rng.Hyperlinks(1).Follow NewWindow:=False, AddHistory:=True

Yay! It worked!

i just had to change this part

.Range("A1").Value = "YOU DID IT!"

to this

ws.Range("A1").Value = "YOU DID IT!"

Thanks so much!