Msgbox vbYesNo if then

Hi all,

I've got a piece of code that takes the user entered responses in a message box to do a set number of things.
I want it to work in a way that if the user clicks no the sheet shuts down and no further code is run. If the user clicks yes I want the code to continue.

As it stands, my code shuts down the document irrespective of what is selected by the user. I understand that this is because the shutting down of the workbook happens outside the If statement, but I don’t know how to correct this so that it does what I would like it to do.


It looks like this at the moment:

Please Login or Register  to view this content.

Any help would be greatly appreciated.

Thanks

Hi, Swoootie,

Your post does not comply with Rule 3 of our Forum RULES. Use code tags around code.

Posting code between [CODE]Please [url=https://www.excelforum.com/login.php]Login or Register [/url] to view this content.[/CODE] tags makes your code much easier to read and copy for testing, it also maintains VBA formatting.

Highlight your code and click the # icon at the top of your post window. More information about these and other tags can be found here



(This thread should receive no further responses until this moderation request is fulfilled, as per Forum Rule 7)

Ciao,
Holger

Hi, Swoootie,

maybe like this:

Please Login or Register  to view this content.

Ciao,
Holger

1) Please use code tags as required by forum rules. It makes reading easier. so go back to first post and edit it using code tags as already asked for.
2) There is missing

Please Login or Register  to view this content.

in your code. Presumably it shall be between exit sub and next if (well this second if could be ommitted or replaced by else), so could read rather:

Please Login or Register  to view this content.

3) As for the code as it is now - seems that SHEET1.xlsm should be closed only if "No" is pressed. Otherwise only sheet Summary shall be selected (may be would be better to have it Activated instead) and all Check procedure shall stop. If it has been called by its name from Macros (Atl+F8) or is assigned to a button - code shall stop at this point.
4) PS. APPROACH is neither defined nor assigned value in part of code you shown.

Hi, Swoootie,

I think it's because the else is after the exit sub.

I dounbt that. My sample compiles fine on my pc (Win 8.1, Excel2013) and performs like expected, no error being raised (I used a standard module for placing the code). The code line

Please Login or Register  to view this content.

could be passed as the sub would be ended by the closing of ThisWorkbook but would need to stay if you want to close a different workbook (where you should make sure that itīs opened in the same instance of Excel).

Ciao,
Holger

Hi, Swoootie,

I would kindly ask you which of my code lines provided doesnīt work as expected as you stick to your original code and apparently have some problems in deciding whether to take a one line If-Statement (no continuation for that check and no End If needed there) or a mulitple line approach (all actions could go into different lines and work for the check just done).

Please Login or Register  to view this content.

This code line is doing all the checks for response and all other codelines that follow will work without the check.

What may help

Please Login or Register  to view this content.

And it would be very good practise to turn on the messages before leaving the Sub. Plus I wonder why you would need to turn the messages off if you close the workbook without changes but thatīs another story.

Ciao,
Holger