Repeat Inputbox if user click cancel or if user enter character not in selection criteria

If by cancel button you mean the X on the top right hand of the form window I would just disable it with the code below and remove your 3rd if statement group from your code.

Place this in the userform vba window:

Please Login or Register  to view this content.

Also note if you haven't already in some other portion of your coding will need an option for it to close on successful form completion.

A message box with two buttons would be a smother user interface

Please Login or Register  to view this content.

If you had to use your code you could have tried to leave the last condition open since it would default if the other 2 didn't happen anyways so you would exit the sub but not end it leaving the window open after the message box. As is it would just loop to the message box if the first to conditions were not met. If it still errord we would need to know which line gives the erorr.



sub data()
Dim NewStaff As Boolean

NewStaff = Application.InputBox("Is there any new staff to be updated?" & vbCrLf & vbCrLf & "Press Y, (Yes)" & vbCrLf & "Press N, (No)")

If NewStaff = "Y" Or NewStaff = "y" Then

Call XXXXXXXXX

ElseIf NewStaff = "N" Or NewStaff = "n" Then

Workbooks("workbookname").Close

ElseIf NewStaff = "" Then

MsgBox ("Please do not press cancel")
Exit Sub
End If

end sub