For Each Loop code issue

[mannalora]

I know this code is very rough, I am very rusty, the 90s seem so recent. I cannot get the macro below to execute properly. It should go through each cell in a defined range read the value and change the cell background to correspond. The If Then nest works properly for each active cell, but cannot get it to loop through the range. Thank you in advance

Sub Color()
' Changes the cell color to correspond to the letter grade
Dim Grade As Range
Set Grade = Range("L16:L33").Text
Grade.Select
    
   For Each Cell In Grade
   
   If Cell.Value = "A" Then
   
    With Selection.Interior
        .Pattern = xlSolid
        .PatternColorIndex = xlAutomatic
        .Color = 5287936
        .TintAndShade = 0
        .PatternTintAndShade = 0
    End With
  End If
  
  If Cell = "C" Then
   
    With Selection.Interior
        .Pattern = xlSolid
        .PatternColorIndex = xlAutomatic
        .Color = 65535
        .TintAndShade = 0
        .PatternTintAndShade = 0
    End With
  End If
  
  Next Cell
    
End Sub

[alansidman]

Code Tags Added
Your post does not comply with Rule 3 of our Forum RULES. Use code tags around code.

Posting code between tags makes your code much easier to read and copy for testing, it also maintains VBA formatting.

Highlight your code and click the # icon at the top of your post window. More information about these and other tags can be found at http://www.excelforum.com/forum-rule...rum-rules.html



(Because you are new to the forum, I have added them for you today. Please take a few minutes to read all Forum Rules and comply in the future.)

[mannalora]

Thank you, I will begin using code tags. I do and will continue to search Google for applicable examples and sample code.

[Kaper]

Try:

Sub Color()
' Changes the cell color to correspond to the letter grade
Dim Grade As Range, Cell as range
Set Grade = Range("L16:L33")
For Each Cell In Grade
  If Cell.Value = "A" Then
    With Cell.Interior
      .Pattern = xlSolid
      .PatternColorIndex = xlAutomatic
      .Color = 5287936
      .TintAndShade = 0
      .PatternTintAndShade = 0
    end With
  End If
  If Cell = "C" Then
    With Cell.Interior
.Pattern = xlSolid
.PatternColorIndex = xlAutomatic
.Color = 65535
.TintAndShade = 0
.PatternTintAndShade = 0
End With
End If
Next Cell
End Sub

[mannalora]

Awesome, Thank you worked perfectly. It looks like the issue was defining Cell? I will add to your reputation

[alansidman]

Try this:

Option Explicit

Sub Color()
' Changes the cell color to correspond to the letter grade
Dim c As Range
Dim Grade As Range
Set Grade = Range("L16:L33")

    
   For Each c In Grade
   
   If c.Value = "A" Then
   c.Interior.Color = 5287936
 
    End If
  
  If c.Value = "C" Then
   c.Interior.Color = 65535

  End If
  
  Next c
    
End Sub

[mannalora]

Thank you, got it I will change status to closed