Macro troubleshoot

[vio.coman]

Hi guys,

I have the following macro, which extracts data from an input file and rearranges it into a master file.
The problem is that it runs the code 3 x times, so the final data in the master file is triple.

Could u please help me out removing this bug!?

Thanks a lot!

Macro:

Please Login or Register  to view this content.

[alansidman]

Code Tags Added
Your post does not comply with Rule 3 of our Forum RULES. Use code tags around code.

Posting code between

Please Login or Register  to view this content.

tags makes your code much easier to read and copy for testing, it also maintains VBA formatting.

Highlight your code and click the # icon at the top of your post window. More information about these and other tags can be found at http://www.excelforum.com/forum-rule...rum-rules.html



(Because you are new to the forum, I have added them for you today. Please take a few minutes to read all Forum Rules and comply in the future.)

[vio.coman]

Hi Alan and thanks! Will do so from now on

[Norie]

Get rid of the Do Until...Loop.

You know the name of the workbook you want to import from, it's hard-coded, so you don't need to loop through all the workbooks in a folder.

[vio.coman]

Thanks Norie

I did so and sadly it's worse than before. I mean, it runs the code once, but it does not import that data anymore ...

[Norie]

That's worse than the code running 3 times?

You need to get rid of the loop and any other code that goes with it, for example the If statement that is checking fname.

Please Login or Register  to view this content.

[vio.coman]

Thanks Norie!

It worked How would the code look like if one would implement the 'Do until - Loop' commands and if let's say, I have several files to be imported lying in the same folder "Macro Test" as the master?

Regards

[Norie]

It would look like the original code, but you wouldn't hard-code the workbook name you are importing from.

[vio.coman]

Exactly!

However, I'm getting a 1004 error on this particular line:

Please Login or Register  to view this content.

That's why I opted for the hard-code...

[Norie]

What code are you using now?

[vio.coman]

It works now as I need it to work, thanks a lot for your help!