Problem renaming files and folders

[Orada]

I am having a problem with the NAME function and failing to understand why. I have a procedure where the user selects a folder and all the contents including subfiles are imported into column 1 of a worksheet.

Following various conditional file changes I build a new path and file name in column 2, all well so far.

After visually verifying the results are what I expect I want to rename the old file and folder name but I get the Filename not Found error despite the entries in column 1 never being edited or changed, what am I missing?

Please Login or Register  to view this content.

[LJMetzger]

Hi Orada,

To help debug your problem try:

Please Login or Register  to view this content.

Also to prevent typos from ruining days and weeks of work you need 'Option Explicit' at the top of each code module.
This forces you to declare every variable.
http://www.cpearson.com/excel/DeclaringVariables.aspx

Lewis

[Orada]

Hi and thank you Lewis,

I copied your code into a new module with the same results.

The debug.print oldfilename and newfilename were exactly as I expected, with the addition of "Old file Name Exists = True" yet I still get the Run-time error '53': File not found on the following line

Please Login or Register  to view this content.

With my limited experience of file operations I simply cannot understand this, unless anyone can suggest where it is going wrong I will need to experiment more and search for possible answers again tomorrow, seems like such a simple command.

[Orada]

Just for clarity and in case I am missing something out of ignorance the drive I am applying this to is a USB connected Hdd and the Excel version is 2007.

[shg]

The old file and the new directory must exist. Name As won't create a directory, and the files must not be open.

[Orada]

Thank you all for your help, stupid of me to think I could rename both the folder and file name at the same time.

I overcome the difficulties with the code below and then similar for the file name, thanks again.

Please Login or Register  to view this content.

[shg]

You're welcome.

[LJMetzger]

Hi again Orada,

Thanks for the rep points, even though shg did most of the work.

You might find the following functions useful in the future when accessing files. The 'Exists' functions are especially useful when loop using the Dir() command, because they use 'getAttr()' which plays nicely with Dir() when Dir() is looping.

Lewis

Please Login or Register  to view this content.