Do Until loop not ending

[Dralky]

The attached document has the problem. I have several problems with this spreadsheet and the VBA I'm building into it, but I hope with this one question answered I may continue. In the sheet JAN I have Button 8 and a macro it runs. The macro of this button should loop through every row in the Alex column and sum each heading (Hours, CC pledges, CC amounts, etc. through Not Home) to its place in the first 12 rows for Alex. It works for the first header (Hours) but then doesn't work for any of the other header types - it gets caught looping infinitely.

Call Report.xlsm

[patel45]

you start with FunctionRow = 3 then open the loop with Do Until FunctionRow = 13 then you increment the value by 23
FunctionRow = FunctionRow + 23
How can the loop end ?

[MrShorty]

One of the debugging tools I use most often is the "set a breakpoint and step through code" (discussion of debugging stratigies: http://office.microsoft.com/en-us/su...819.aspx?CTT=1). I would strongly suggest you become familiar with this strategy.

Following the variable Functionrow (which controls when the outer loop should end) I see:

Function row = 3
enter outer loop -- check if function row = 13
It does not, so execute the loop
Inside the loop, 23 is added to function row (functionrow=26)
Continue inner loop (adding 23 each time)
When it gets back to checking functionrow=13, functionrow=717. still false, so continue executing
It seems that functionrow would never be equal to 13, so the loop never ends.

I'm not sure exactly what you are trying to do here, so I would suggest you review your logic and flow control (specifically, how you are manipulating functionrow) and see what you need to do to get it to increment up to 13 rather than skipping over 13.

[Dralky]

I see what you mean. Further down in the code I have FunctionRow = FunctionRow + 1 in order to iterate to the next type (hours, CC Pledges, etc.). Should I have 2 different variables, then, one to move by 23 lines to jump from one date to the next and another to reset to the next header type?

[MrShorty]

Adding another counter variable does seem like one possible solution.

[Dralky]

SOLVED - thank you all!

The top declaration now reads
DateRow = 24
TotalSum = 0
TestDate = CDate(Cells(DateRow, 2))
PrintRow = 3
FunctionRow = PrintRow + 23

At the end of the loop the following is performed
PrintRow = PrintRow + 1
DateRow = 24
TestDate = CDate(Cells(DateRow, 2))
TotalSum = 0

PrintRow has thus become the macro counter and controls FunctionRow, the micro counter.