Good practice for working with variables?

When I create macro I often define my variables at the beginning of procedures, and then use them and pass them to other functions if needed. Like this:

Please Login or Register  to view this content.

Is this good practice or does this waste memory in some way?

For example, would the following be better:

Please Login or Register  to view this content.